Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement algorithm parameter for .series() #39889

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Implement algorithm parameter for .series() #39889

wants to merge 2 commits into from

Conversation

user202729
Copy link
Contributor

@user202729 user202729 commented Apr 5, 2025 •
edited
Loading

See #6119

Instead of deprecating it, this just add algorithm=maxima. Which is less intrusive.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 5, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 632af5d; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@user202729 user202729 force-pushed the series-algorithm-maxima branch from cb73830 to 69313ee Compare April 5, 2025 15:11
@user202729 @tscrim
Apply suggestions from code review
632af5d 
Co-authored-by: Travis Scrimshaw <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tscrim tscrim tscrim left review comments

Assignees
No one assigned
Labels
s: needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@user202729 @tscrim