Draft
Conversation
soifou
force-pushed
the
refactor/luasnip-source
branch
from
8539836 to
2ed5d8e
Compare
blink.cmp v1.0.0 has been release 8 months ago, this check can be safely removed now.
Instead of displaying only `trigger`, first try to generate the preview from the snippet's textNodes; if that's not available, fall back to `docTrig` if it exists, or use the `trigger` as a last resort.
This setting, which prefers `docTrig` over the trigger, is confusing and has seen little adoption despite its usefulness. Users can still opt out in v1.0, but the option will be removed in v2.0 to simplify the codebase.
Update lua annotations using refactor branch Fix `docTrig` replacement using Luasnip v2.4.1 Add initial support for choice nodes
soifou
force-pushed
the
refactor/luasnip-source
branch
from
2ed5d8e to
a280624
Compare
Owner
|
This looks great, any blockers for merging this? |
Collaborator
Author
|
Yep, this only works on the latest LuaSnip We could either wait for the next stable LuaSnip release or remove the version pin from docs but this would breaks user configs, so not recommended. I can backport the few ChoiceNode methods to be compatible with stable |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some refactoring on this source for easier maintenance with better annotations.
A potential fix for Duplicate snippets with Luasnip preset #1081. Possibly a race condition causing duplicated snippets due to premature cache initialization. I haven't been able to reproduce it myself, so if anyone wants to test it out, that'd be great!
The
insertTextis "improved" to be more like other snippet engines or LSPs. For example, for awhile~snippet, it showswhi|le true doinstead of the actualwhi|le, with support of multi-line snippets, etc., (fallback to the label/trigger). I think it'd align better with what we observe elsewhere.Deprecation of
opts.prefer_doc_trig(defaulttrue, to be removed inv2) since it has proven very useful and reliable over the months since its introduction.Show blink.cmp completion window for choices as for now we don't have any.
TODO: