Open
Conversation
When I maintain my fork it is hard to pull becuase it is unclear which version was used to test and build the frizbee. Sometimes new features are used or some version are just unstable. I propose to fix the nightly channel in the rust toolchain toml this and update it accordingly. This will make it easier to maintain libraries and forks
Owner
|
Do you mind sharing some code examples of how it makes it difficult? Losing the ability to use a |
Owner
|
I've marked any non-alphanumeric as a delimiter in #52 so the |
saghen
force-pushed
the
main
branch
3 times, most recently
from
30d10ea to
efc3f88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is literally fixing the pain point of the public API and improves the usage of internal tooling (less explicit dereferences) even though the performance impact is minimal this is very annoying that you need to copy that is anyway stack allocated by the compiler.
Like for example in a loop I can not simply move the frizbee config in the block and modify the options for max typos for example I have to deal with the ownership which sometimes becomes tricky