Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/keywords/properties.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,4 +108,15 @@ describe("keyword : properties : validate", () => {

assert.deepEqual(errors.length, 1);
});

it("should validate undefined properties with boolean schema `false`", () => {
const { valid } = compileSchema({
type: "object",
properties: {
header: false
}
}).validate({ header: undefined });

assert.equal(valid, true);
});
});
9 changes: 6 additions & 3 deletions src/keywords/properties.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,14 @@ function validateProperties({ node, data, pointer, path }: JsonSchemaValidatorPa
const errors: ValidationResult[] = [];
const properties = node.properties ?? {};
Object.keys(data).forEach((propertyName) => {
if (properties[propertyName] == null) {
const value = getValue(data, propertyName);
const propertyNode = properties[propertyName];

if (propertyNode == null || value === void 0) {
return;
}
const propertyNode = properties[propertyName];
const result = validateNode(propertyNode, getValue(data, propertyName), `${pointer}/${propertyName}`, path);

const result = validateNode(propertyNode, value, `${pointer}/${propertyName}`, path);
errors.push(...result);
});
return errors;
Expand Down