add isJsonSchema and isBooleanSchema typeguards, update public method#102
add isJsonSchema and isBooleanSchema typeguards, update public method#102sagold merged 3 commits intosagold:mainfrom
Conversation
… signatures to support BooleanSchema
|
Hi Aditya, thank you for the PR! Two things that should be added to the PR to be complete:
Let me know if you have any questions. |
|
Hi @sagold, All 904 unit tests passing. Let me know if anything else is needed |
|
Hi Aditya, thank you so much. I just have one last question: does this work with and can we have a test for this? The type explicitly states that this should work. |
|
Hi @sagold, Pushed the latest updates:
Let me know if anything else is needed! |
|
Will merge your PR and publish it after some tests. Thank you for your contribution! |
@sagold,
Added
isJsonSchemaandisBooleanSchematypeguards intypes.tsUpdated
compileSchemaandaddRemoteSchemasignatures to acceptJsonSchema | BooleanSchemaAdded
isJsonSchemaguard inaddRemoteSchemaimplementationSchemaNode.schemaleft unchanged for now (follow-up PR)