SCO-182: fix entity linking #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is failing again due to Mocks, but it builds locally. |
|
This LGTM @bjones86 thank you very much. I think we need this in 22.x, I'm migrating an instance to 22.x with the SCORM player. |
mpellicer
approved these changes
Aug 2, 2023
|
Yup, no worries. I plan on merging this all the way back to 21.x. Just doing a bit of testing locally before I merge. |
bjones86
added a commit
that referenced
this pull request
Aug 2, 2023
(cherry picked from commit 63f0fae)
bjones86
added a commit
that referenced
this pull request
Aug 2, 2023
(cherry picked from commit 63f0fae)
bjones86
added a commit
that referenced
this pull request
Aug 2, 2023
(cherry picked from commit 63f0fae)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://sakaiproject.atlassian.net/browse/SCO-182
TL;DR: there has been no entity linking for SCORM modules in Sakai 20+