Eslint v9 Migration: Foundation stylelint rules migration to eslint v9 (hardcoded rules) #203

riteshiitbbs007 · 2025-07-02T07:08:59Z

This PR migrates stylelint rule**(no-hardcoded-values-slds1/slds2)** to ESLint v9 while ensuring robust support for both stylelint-plugin-slds and eslint-plugin-slds on style files. By default, the CLI now runs both linters on CSS/SCSS/etc. files for maximum coverage and migration safety. All logic is programmatically controlled—no CLI flag required.

* using esbuild to bundle shared-util * Rules metadata moved to shared utils * cleaning package json before pack and publish for removing slds-shared-utils

packages/cli/src/services/lint-runner.ts

sf-nithappu · 2025-07-21T17:00:54Z

@riteshiitbbs007
If we can bundle without publishing files from other package in monorepo, what is the need/advantage of move utills to separate folder? We can aswell refer utils from style-lint package and bundle them as part eslint package.

riteshiitbbs007 · 2025-07-21T17:15:04Z

@sf-nithappu I feel this provides a clean architecture which supports ESLint-first future.
I feel transition becomes easy when we start using this, might be a little overhead now but i feel most of the heavy-lifting is taken care of.

// Phase 1: Both platforms use shared utils
stylelint-plugin-slds ← slds-shared-utils -> eslint-plugin-slds

// Phase 2: Gradual stylelint deprecation
(deprecated) stylelint-plugin-slds eslint-plugin-slds -> slds-shared-utils

// Phase 3: ESLint-only future
eslint-plugin-slds -> slds-shared-utils

sf-nithappu · 2025-07-22T04:34:44Z

@riteshiitbbs007 we can make use of plugin to bundle required files from stylelint plugin in much clearer way with less changes #220

riteshiitbbs007 · 2025-07-22T06:25:19Z

@sf-nithappu I still feel for all files the imports will not be as easy as ruleMetadata here, also won't it bring an additional change when deprecating stylelint to refactor ESLint and bring those code in here?
I still think shared util should be a way forward unless i am not getting the nuances involved with introducing it.
cc: @KishoreNemalipuri

…essfully enables you to retain packages: 'external' while ensuring slds-shared-utils gets bundled correctly

packages/cli/src/services/lint-runner.ts

packages/cli/src/utils/config-utils.ts

packages/eslint-plugin-slds/gulpfile.mjs

sf-nithappu · 2025-07-21T14:54:11Z

packages/eslint-plugin-slds/src/index.ts

+import noHardcodedValuesSlds2 from './v9/rules/no-hardcoded-values-slds2';
+import cssPlugin from "@eslint/css";
+
+const rules = {


move to new file and export rules object. Helps in implementing internal persona

@sf-nithappu can we do this in a separate PR once this lands?

Needed but not necessarily in this PR

packages/slds-shared-utils/src/boxShadowValueParser.ts

packages/slds-shared-utils/src/declUtils.ts

sf-nithappu · 2025-07-22T13:39:12Z

packages/eslint-plugin-slds/package.json

-    "@salesforce-ux/sds-metadata": "^0.2.4"
+    "@salesforce-ux/sds-metadata": "^0.2.4",
+    "postcss-value-parser": "^4.2.0",
+    "slds-shared-utils": "*"


Adding "slds-shared-utils as dependency is not required

@sf-nithappu I see, beacuse of Monorepo Workspace Resolution it will work without this but isn't this better to keep for Clarity? Does keeping this pose any issue?

No its not. Remove entry or add it under devdependencies. This pkage is need only during dev.

was already removed.

sf-nithappu · 2025-07-22T13:39:23Z

packages/eslint-plugin-slds/package.json

-    "prepublishOnly": "clean-pkg-json"
+    "prepack": "npm pkg delete dependencies.slds-shared-utils",
+    "postpack": "npm pkg set dependencies.slds-shared-utils='*'",
+    "prepublishOnly": "npm pkg delete dependencies.slds-shared-utils && clean-pkg-json"


revert these lines

packages/cli/src/services/lint-runner.ts

packages/cli/src/executor/index.ts

packages/eslint-plugin-slds/gulpfile.mjs

packages/stylelint-plugin-slds/src/rules/enforce-component-hook-naming-convention/index.ts

packages/stylelint-plugin-slds/src/rules/enforce-sds-to-slds-hooks/index.ts

…y treating internal modules as external imports

sf-nithappu · 2025-07-23T11:42:55Z

packages/eslint-plugin-slds/src/utils/cssHandlers.ts

300 lines file, can be modularise.

riteshiitbbs007 added 5 commits June 23, 2025 19:04

feat: eslint v9 migration for eslint-plugin-slds

4bd7721

Folder structure for adding v9 specific rules

c990320

More explicit rule export for v8/v9 specific rules

bfe49fc

Merge branch 'develop' into feat-stylelint-eslint-v9

d26bfd9

slds/no-hardcoded-values-slds1 eslint v9 migration

e6ad223

riteshiitbbs007 changed the title ~~Feat stylelint rules migration to eslint v9~~ (WIP) Feat stylelint rules migration to eslint v9 Jul 2, 2025

sf-nithappu temporarily deployed to slds-linter-pr-203 July 2, 2025 07:09 Inactive

minor change

255520e

sf-nithappu temporarily deployed to slds-linter-pr-203 July 2, 2025 07:42 Inactive

working fine: correct location and text, value iwth unit coming

b1584a5

sf-nithappu temporarily deployed to slds-linter-pr-203 July 2, 2025 11:00 Inactive

refactor

598725c

sf-nithappu temporarily deployed to slds-linter-pr-203 July 2, 2025 11:04 Inactive

riteshiitbbs007 added 2 commits July 2, 2025 16:54

Merge branch 'develop' into feat-eslint-v9

d43988f

Merge branch 'feat-eslint-v9' into feat-stylelint-eslint-v9

1c18540

sf-nithappu temporarily deployed to slds-linter-pr-203 July 2, 2025 11:51 Inactive

Reverting reporting 0 testcases and fixing code

ce0e279

sf-nithappu temporarily deployed to slds-linter-pr-203 July 2, 2025 12:13 Inactive

Supporting both hardcoded slds1 and slds2 rules in eslint v9

05ebd21

sf-nithappu temporarily deployed to slds-linter-pr-203 July 2, 2025 13:07 Inactive

refactoring code

b288acd

sf-nithappu temporarily deployed to slds-linter-pr-203 July 2, 2025 13:32 Inactive

adding postcss value parser direct dependency in eslint

38faa6e

sf-nithappu temporarily deployed to slds-linter-pr-203 July 3, 2025 04:58 Inactive

major refactor: removing unnecessary dependency in eslint rules

c16ba04

sf-nithappu temporarily deployed to slds-linter-pr-203 July 3, 2025 07:02 Inactive

feature flag set to use eslint rules for styles

6e80284

sf-nithappu temporarily deployed to slds-linter-pr-203 July 3, 2025 08:23 Inactive

major refactor: working and introduces reusable code for eslint rules

473c816

sf-nithappu temporarily deployed to slds-linter-pr-203 July 3, 2025 13:56 Inactive

riteshiitbbs007 added 3 commits July 21, 2025 14:35

Shared Utils Migration: Stylelint to ESLint v9 Rules Migration (#214)

7a693e3

* using esbuild to bundle shared-util * Rules metadata moved to shared utils * cleaning package json before pack and publish for removing slds-shared-utils

readme cleanup

e298187

reverted unnecessary commenting of definition

39ad360

sf-nithappu added the under review PR review is active and in progress label Jul 21, 2025

kenamverma reviewed Jul 21, 2025

View reviewed changes

packages/cli/src/services/lint-runner.ts Outdated Show resolved Hide resolved

riteshiitbbs007 added 5 commits July 22, 2025 15:26

refactor

e3eeafd

cleanup

104b1e0

revert unnecessaryc hanges

7e7cfdf

revert unnecessaryc hanges

362d24c

The implementation follows the exact same pattern as PR #220 and succ…

3aa9566

…essfully enables you to retain packages: 'external' while ensuring slds-shared-utils gets bundled correctly

sf-nithappu requested changes Jul 22, 2025

View reviewed changes

packages/cli/src/services/lint-runner.ts Outdated Show resolved Hide resolved

packages/cli/src/executor/index.ts Outdated Show resolved Hide resolved

sf-nithappu requested changes Jul 22, 2025

View reviewed changes

packages/eslint-plugin-slds/gulpfile.mjs Outdated Show resolved Hide resolved

sf-nithappu requested changes Jul 22, 2025

View reviewed changes

packages/stylelint-plugin-slds/src/rules/enforce-component-hook-naming-convention/index.ts Show resolved Hide resolved

packages/stylelint-plugin-slds/src/rules/enforce-sds-to-slds-hooks/index.ts Show resolved Hide resolved

riteshiitbbs007 added 4 commits July 22, 2025 23:34

shared esbuild-plugin created

ba962c5

Fixed stylelint gulpfile interferes with esbuild's bundling process b…

3ad701d

…y treating internal modules as external imports

Working refactor for review comments

3878e5c

revert unnecessary changes

39c3a51

riteshiitbbs007 requested review from sf-nithappu and kenamverma July 23, 2025 10:31

sf-nithappu reviewed Jul 23, 2025

View reviewed changes

riteshiitbbs007 added 3 commits July 23, 2025 19:03

Modular cssHandlers and few otehr comments resolved

8b61b03

Merge branch 'develop' into feat-stylelint-eslint-v9

bded5c5

fix after merge

b24dd84

riteshiitbbs007 requested a review from sf-nithappu July 23, 2025 18:44

use workspace:* for Consistent dependency resolution across environments

58a4e36

Eslint v9 Migration: Foundation stylelint rules migration to eslint v9 (hardcoded rules) #203

Are you sure you want to change the base?

Eslint v9 Migration: Foundation stylelint rules migration to eslint v9 (hardcoded rules) #203

Uh oh!

Conversation

riteshiitbbs007 commented Jul 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

sf-nithappu commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

riteshiitbbs007 commented Jul 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sf-nithappu commented Jul 22, 2025

Uh oh!

riteshiitbbs007 commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sf-nithappu Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

riteshiitbbs007 commented Jul 2, 2025 •

edited

Loading

sf-nithappu commented Jul 21, 2025 •

edited

Loading

riteshiitbbs007 commented Jul 21, 2025 •

edited

Loading

riteshiitbbs007 commented Jul 22, 2025 •

edited

Loading

sf-nithappu Jul 22, 2025 •

edited

Loading