Update the return typehints for the fluent methods on the Paginator. #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the return typehints for two of the fluent methods on the Paginator. The
setMaxPages()
andsetPerPageLimit()
methods were defined to returnPaginator
instances, but this has been updated to use thestatic
keyword. This improves intellisense in IDEs.For example, if you have the following method chain (connector is using a
PagedPaginator
):In this example, intellisense will complain that the
pool()
method doesn't exist. This is because thesetPerPageLimit()
is defined to return aPaginator
instance, and that does not have thepool()
method defined. However, the method actually returns aPagedPaginator
, which does have thepool()
method, and will work correctly. By updating the return type tostatic
, intellisense will be able to resolve the correct returned instance type and see that thepool()
method is valid.As a note, the
setStartPage()
fluent method already correctly uses thestatic
return typehint, so this is not a new thing for this class.