-
Notifications
You must be signed in to change notification settings - Fork 194
Simplify WaitGroup implementation
#958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify WaitGroup implementation
#958
Conversation
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #958 will degrade performances by 5.28%Comparing Summary
Benchmarks breakdown
|
|
Is there any other benefit than code size reduction. It seems codspeed doesn't like it at all. |
7a3884e to
ef1c5dc
Compare
|
No there isn't. I was curious about the perf impact, I agree this isn't great. Checking if we can actually simplify our impl now |
ef1c5dc to
1b15e41
Compare
WaitGroup impl with crossbeam'sWaitGroup implementation
|
Hm, we could get rid of the additional |
|
@ibraheemdev could you take a look at this PR? |
f1f158f to
ee184dd
Compare
Co-authored-by: Ibraheem Ahmed <[email protected]>
ee184dd to
9b4da36
Compare
No description provided.