Manage templates repositories for Packer#12
Manage templates repositories for Packer#12kartnico wants to merge 1 commit intosaltstack-formulas:masterfrom
Conversation
|
Best reviewed: commit by commit
Optimal code review plan
|
|
Thanks for the PR, @kartnico -- let's try to get some eyes on it from people who have previously contributed to this formula. @arthurlogilab @andreimoustache Would either of you be able to glance at this PR and give some general feedback. If it's OK with either of you, we can go ahead and merge. |
arthurzenika
left a comment
arthurzenika
left a comment
There was a problem hiding this comment.
The example repo is still on master and not main, maybe we can find an example repo that has switched to main instead of master.
Cf https://github.com/github/renaming/ and https://github.blog/changelog/2020-07-17-links-to-deleted-branches-now-redirect-to-the-default-branch/
| templates: | ||
| ubuntu: | ||
| address: https://github.com/boxcutter/ubuntu.git | ||
| revision: master |
There was a problem hiding this comment.
| revision: master | |
| revision: main |
| Install packer and add it to PATH | ||
|
|
||
| ``packer.templates`` | ||
| ---------- |
There was a problem hiding this comment.
| ---------- | |
| -------------------- |
|
This is exactly why it's so important to get the right feedback. Really appreciate your review, @arthurlogilab! |
3 participants
PR progress checklist (to be filled in by reviewers)
What type of PR is this?
Primary type
[build]Changes related to the build system[chore]Changes to the build process or auxiliary tools and libraries such as documentation generation[ci]Changes to the continuous integration configuration[feat]A new feature[fix]A bug fix[perf]A code change that improves performance[refactor]A code change that neither fixes a bug nor adds a feature[revert]A change used to revert a previous commit[style]Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)Secondary type
[docs]Documentation changes[test]Adding missing or correcting existing testsDoes this PR introduce a
BREAKING CHANGE?No.
Related issues and/or pull requests
Describe the changes you're proposing
Manage templates repositories for Packer, like Bento project from Chef
Documentation checklist
README(e.g.Available states).pillar.example.