Skip to content

Conversation

@s-t-e-v-e-n-k
Copy link

pytest fixtures are now executed in the order they are found, which means a redeclared fixture will take precedence. This means that an attempt to spin up the salt_factories fixture in the container integration tests now has a dependency loop. Remove the overloaded fixture, and perform the check further up the fixture chain.

pytest fixtures are now executed in the order they are found, which
means a redeclared fixture will take precedence. This means that an
attempt to spin up the salt_factories fixture in the container
integration tests now has a dependency loop. Remove the overloaded
fixture, and perform the check further up the fixture chain.
@s-t-e-v-e-n-k s-t-e-v-e-n-k requested a review from a team as a code owner November 28, 2025 04:03
@s-t-e-v-e-n-k s-t-e-v-e-n-k requested review from twangboy and removed request for a team November 28, 2025 04:03
@twangboy twangboy added the bug Something isn't working label Dec 1, 2025
@dwoz
Copy link

dwoz commented Dec 1, 2025

@s-t-e-v-e-n-k pre-commit is failing.

@s-t-e-v-e-n-k
Copy link
Author

Run bandit against Salt..................................................Failed
- hook id: bandit
- exit code: 1

Traceback (most recent call last):
  File "/home/runner/.cache/pre-commit/repor8zcz89w/py_env-python3/bin/bandit", line 3, in <module>
    from bandit.cli.main import main
  File "/home/runner/.cache/pre-commit/repor8zcz89w/py_env-python3/lib/python3.11/site-packages/bandit/__init__.py", line 5, in <module>
    import pbr.version
ModuleNotFoundError: No module named 'pbr'

@dwoz That seems like a more fundamental CI issue to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants