Update emotion support (MUI latest version) and add support for Node with ESM#45
Open
dgadelha wants to merge 5 commits into
Open
Update emotion support (MUI latest version) and add support for Node with ESM#45dgadelha wants to merge 5 commits into
dgadelha wants to merge 5 commits into
Conversation
when a project uses type = module, require doesn't work .cjs extension is needed to ensure code will be loaded otherwise an error will be thrown
it needs Buffer support, which is not available in the browser LZString lib can handle this correctly
Author
|
Locally, I've replaced this code with const isProd = () => {
return true;
};but that doesn't seem to be the best option. I think maybe it is because the components (head, document) import the helpers.js, code that is ran client-side and fails. I was only able to run this code with NODE_ENV=production, though. webpack-dev-server integration seems incomplete on 0.25.0-canary.2
EDIT: fixed on last commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@emotion/reactinstead of@emotion/core[reference]keyto Emotion'screateCachemethod, which is now required [reference]ssr.config.cjs, as Node.js with ESM (package.json's"type": "module"doesn't allow require of .js files [reference]urlsafe-base64, as it relies onBufferAPI, which is not available in the browser