hack: conditionally set samba specifics value based on source #198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: John Mulligan <[email protected]>
Set the ctdb_rados_mutex_skip_reg samba specifics flag when we're consuming samba master builds - IOW our nightly or devbuilds source. This allows sambacc to disable registering the rados mutex helper as a ceph service. Signed-off-by: John Mulligan <[email protected]>
avanthakkar
approved these changes
Mar 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally set the samba specifics value for ctdb_rados_mutex_skip_reg based on source. When the source is a samba master build (nightly, devbuilds) we want to set this specifics flag.
Reformat source of
hack/build-imagewith black as I noticed it had many small issues when reading it over today.