Skip to content

Conversation

@xhernandez
Copy link
Collaborator

This patch removes the requirement of CentOS 8 Stream for the storage nodes of the GPFS backend. That requirement was needed because of an incompatibility of the CentOS 9 Stream's ansible version and the ansible playbooks of the Storage Scale installer.

Updates: #102

@xhernandez
Copy link
Collaborator Author

/retest centos-ci/gpfs

1 similar comment
@xhernandez
Copy link
Collaborator Author

/retest centos-ci/gpfs

Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the changes LGTM, but wondering if " Updates: #102" in the description and commit message should be "Resolves:" or "Fixes:" ...

@xhernandez
Copy link
Collaborator Author

the changes LGTM, but wondering if " Updates: #102" in the description and commit message should be "Resolves:" or "Fixes:" ...

There are two backends affected by the EOL of CentOS 8 Stream: GPFS and GlusterFS. This PR only tries to fix part of the problem. We'll need to decide what to do with GlusterFS and, maybe, send another patch to fix it. Using "Fixes" would close the issue once the PR is merged, which I don't want. I thought "Updates" is good enough (we used this for multi-patch issues in GlusterFS).

obnoxxx
obnoxxx previously approved these changes Jun 10, 2024
Copy link
Collaborator

@obnoxxx obnoxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anoopcs9
Copy link
Collaborator

anoopcs9 commented Jun 16, 2025

/retest centos-ci/xfs

Copy link
Collaborator

@anoopcs9 anoopcs9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@anoopcs9 anoopcs9 merged commit 78cb88d into samba-in-kubernetes:main Jun 17, 2025
7 of 8 checks passed
@xhernandez xhernandez deleted the centos9s-gpfs branch June 17, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants