-
Notifications
You must be signed in to change notification settings - Fork 7
Use default OS for GPFS storage nodes #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/retest centos-ci/gpfs |
1 similar comment
|
/retest centos-ci/gpfs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the changes LGTM, but wondering if " Updates: #102" in the description and commit message should be "Resolves:" or "Fixes:" ...
There are two backends affected by the EOL of CentOS 8 Stream: GPFS and GlusterFS. This PR only tries to fix part of the problem. We'll need to decide what to do with GlusterFS and, maybe, send another patch to fix it. Using "Fixes" would close the issue once the PR is merged, which I don't want. I thought "Updates" is good enough (we used this for multi-patch issues in GlusterFS). |
obnoxxx
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
5c73850 to
eac9722
Compare
eac9722 to
4044af1
Compare
Updates: samba-in-kubernetes#102 Signed-off-by: Xavi Hernandez <[email protected]>
9724368 to
227f5c5
Compare
|
/retest centos-ci/xfs |
anoopcs9
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm.
This patch removes the requirement of CentOS 8 Stream for the storage nodes of the GPFS backend. That requirement was needed because of an incompatibility of the CentOS 9 Stream's ansible version and the ansible playbooks of the Storage Scale installer.
Updates: #102