Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji toolbox tool #947

Closed
wants to merge 5 commits into from
Closed

Emoji toolbox tool #947

wants to merge 5 commits into from

Conversation

juhojama
Copy link

@juhojama juhojama commented Nov 3, 2023

This PR adds optional unicode emoji selector in toolbar. The existing emoticon support may not be fit for all use cases so now the user has option to use unicode emojies or image emoticons.

Use it by adding preferred emojies in SCEditor initialization:

sceditor.create(textarea, {
	format: 'bbcode',
	style: 'https://cdn.jsdelivr.net/npm/sceditor@3/minified/themes/content/default.min.css',
	emojies: ['😊', '❤️', '😄']
});

image

@samclarke
Copy link
Owner

Thanks for the PR, it looks really good!

It might be better to have it as a plugin instead of in the default code as not everyone wants emoticons/emoji. I know the emoticon code isn't in a plugin but that's stuck there due to backwards compatibility otherwise I'd move that too.

If you could move it into a plugin I'll get it merged ASAP.

@samclarke samclarke added this to the v3.3.0 milestone Jan 15, 2024
@juhojama
Copy link
Author

Thanks @samclarke. I was unable to replicate the plugin implementation on my end, but feel free to use the changes in the PR yourself to make a plugin adaption.

@w8tcha
Copy link
Contributor

w8tcha commented Mar 21, 2024

@juhojama i created a new PR based on your work but as a plugin implementation.

#956

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants