Skip to content

Enable Go 1.25 JSONv2 Experiment #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Enable Go 1.25 JSONv2 Experiment #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,13 @@ jobs:
version: v2.5.0

- name: Test
run: go test -v ./...
run: make test

- name: Fuzz Test
run: go test -fuzz=FuzzCalculateFileChunks -fuzztime=10s ./util

- name: Build
run: go build .
run: make build

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@76621b61decf072c1cee8dd1ce2d2a82d33c17ed # v3
Expand Down Expand Up @@ -117,6 +117,7 @@ jobs:
- name: Build
env:
CGO_ENABLED: '0'
GOEXPERIMENT: 'jsonv2'
GOOS: ${{ matrix.os }}
GOARCH: ${{ matrix.arch }}
run: go build .
Expand Down
10 changes: 10 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
lint:
golangci-lint run

test:
GOEXPERIMENT=jsonv2 go test ./...

build:
GOEXPERIMENT=jsonv2 go build .

.PHONY: lint test build
2 changes: 1 addition & 1 deletion fhir/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -494,7 +494,7 @@ func TestPollAsyncStatus(t *testing.T) {

_, err := pollAsyncStatus(server)

assert.Equal(t, "error while reading the outcome of an error response in the async response bundle: json: cannot unmarshal array into Go value of type fhir.OperationOutcome", err.Error())
assert.Equal(t, "error while reading the outcome of an error response in the async response bundle: json: cannot unmarshal JSON array into Go type fhir.OperationOutcome", err.Error())
})

t.Run("async response with error bundle entry with outcome", func(t *testing.T) {
Expand Down