Update some feature for device #34
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wkd8176
commented
Jul 9, 2019
wkd8176
commented
- mac address for same type device
- model name and model type for specific model division
- option item to get option item for searching each device's support function
- reference comment for looking up reference commene -> korean dryer has korean comment so i used this
- set ac wdirstep for AC's wind direction step function
- delete permission for using mobile app and HA at the same time
- get power data for AC power consumption
- get water usage for water purifier usage
- get dust sensor data for AC dust sensor data which has dust sensor
1. mac address for same type device 2. model name and model type for specific model division 3. option item to get option item for searching each device's support function 4. reference comment for looking up reference commene -> korean dryer has korean comment so i used this 5. set ac wdirstep for AC's wind direction step function 6. delete permission for using mobile app and HA at the same time 7. get power data for AC power consumption 8. get water usage for water purifier usage 9. get dust sensor data for AC dust sensor data which has dust sensor
sampsyo
reviewed
Jul 9, 2019
| DEFAULT_COUNTRY = 'US' | ||
| DEFAULT_LANGUAGE = 'en-US' | ||
| #: Represents an unknown enum value. | ||
| _UNKNOWN = 'Unknown' |
Owner
There was a problem hiding this comment.
Looks like some stray whitespace snuck in here (and elsewhere in this file)?
|
|
||
| @property | ||
| def model_type(self): | ||
| """ get model type""" |
Owner
There was a problem hiding this comment.
What is the return type of this function? It would be useful to know what kind of data to expect from the API.
| self.client.session.set_device_controls( | ||
| self.device.id, | ||
| value, | ||
| ) |
Owner
There was a problem hiding this comment.
This method doesn't seem to be called anywhere. Can you clarify what it's useful for?
| if code != '0000': | ||
| raise MonitorError(device_id, code) | ||
| else: | ||
| return data |
Owner
There was a problem hiding this comment.
These methods seem to be AC-specific. Maybe they should be located in the ac module?
Collaborator
Th3AL0
reviewed
Feb 23, 2021
| from typing import Any, Optional | ||
|
|
||
| from . import core | ||
| from . import core |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.