-
Notifications
You must be signed in to change notification settings - Fork 179
Fix BGZF block size to be 64 kilobyte #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The maximum uncompressed and compressed block sizes are clearly described in the paragraph after the table (“The random access method to be described next […]”), so this is just a clarification rather than a fix. We use such abbreviations in a number of these specifications:
Here in 2025, do we feel that the kibi/mebi/etc prefixes are familiar enough for these specifications' readers that we can use them without comment? Then we can be very clear in distinguishing the radix difference between binary mebibytes and decimal megabases. IMHO “and” and “or” are equivalent in this prose. But happy to change it for clarity, perhaps to “each no larger |
|
Thanks for your effort of checking all of the other specifications, too. KiB is probably an even more precise notation. I'd be happy to change it. |
|
I'm happy with KiB notations where relevant. Also thanks for this PR, but like John I'm less sure on the "or" / "and" text. I'm easy on that though. |
|
Thank you for your comments; I have integrated the suggestions. |
|
That was more of a commentary for the maintainers of the other specifications than a request for you to make all those changes… 😄 It's actually easier to consider changes to the different format specifications separately (in particular, because they need to be reviewed and merged by different people), so I have split this into additional #840 and #841 PRs accordingly. I"ll change this PR back to contain only the SAMv1.tex changes; after this, I believe we have enough agreement from both @jkbonfield and myself to merge this trivial wording change. |
4e71cd1 to
b5341fb
Compare
|
Given the confusion of bases vs bytes, some people use bp for base-pairs. I accept Kb vs kb is different, so maybe it's not an issue. However see https://en.wikipedia.org/wiki/Base_pair#As_a_unit_of_length which suggest bp. Note technically it's not true for single stranded things such as RNA and they suggest nt there, but I think that just makes it even more confusing and generally we're talking about DNA here. |
This commit fixes two small issues.
bmight be interpreted asbit.