Remove useMemo in component export, refactor MetadataDisplay component #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #630
Refactor
MetadataDisplay
component's calculated UI portions to re-render only when relevant state variables are changed usingReact.useMemo
hook.Use the same concept in other mostly static components refactored in #640, instead of wrapping the component export in
React.useMemo
.The implementation in #640 with
React.useMemo
was still emitting a warning react-styleguidist docs regardless of the styleguidist config changes. And with this implementation we can still limit the re-renders to the entire component and export pure components for react-styleguidist to use to generate documents.