Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent solr error when missing parent ids #13

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Prevent solr error when missing parent ids #13

wants to merge 2 commits into from

Conversation

masaball
Copy link
Contributor

This PR also includes updates to allow testing against Ruby > 3 and Rails > 7

@masaball
Prevent solr error from missing parent ids
9f8ca58 
Update bundler version. Remove tests for old ruby/rails.

Use 7.2 compatible active_fedora
cjcolvar
cjcolvar reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but it would be nice to merge the ActiveFedora changes first so this PR can be updated to point to an actual release.

lib/speedy_af/base.rb Outdated Show resolved Hide resolved
Rakefile Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjcolvar cjcolvar cjcolvar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masaball @cjcolvar