Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💄 Match catalog search results match to Hyrax #2344

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

kirkkwang
Copy link
Collaborator

@kirkkwang kirkkwang commented Sep 20, 2024

Summary

💄 Match catalog search results match to Hyrax

89a755c

This commit will along the look of the catalog search results page to
look closer to the way Hyrax looks. The problem stems from the
markdown feature. For plain text it adds a <p> tag which has a margin
bottom. I think the best thing to do is turn it off for default and any
tenant that is currently using it should turn it back on.

Screenshots

Before

image

After

image

From PG Nurax

image

@kirkkwang kirkkwang added the patch-ver for release notes label Sep 20, 2024
ShanaLMoore
ShanaLMoore previously approved these changes Sep 20, 2024
sjproctor
sjproctor previously approved these changes Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

Test Results

    3 files  ±0      3 suites  ±0   17m 58s ⏱️ -26s
2 038 tests +1  1 988 ✅ +1  50 💤 ±0  0 ❌ ±0 
2 065 runs  +1  2 013 ✅ +1  52 💤 ±0  0 ❌ ±0 

Results for commit 89a755c. ± Comparison against base commit d6892bf.

This pull request removes 43 and adds 44 tests. Note that renamed tests count towards both.
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 280991b3-2267-450f-a343-4f524aba82bb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 6af1c07e-4651-4068-9b25-3141efae472b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read b47a724a-d9d0-43bd-912d-15b51e695219
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update ecc39c34-3bdf-4164-acae-31649042d8f9
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy 4fdfc3f5-59e5-4333-86db-159311e471b3
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit 360eb302-9842-4fae-b7c6-f02c08817f92
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 8142caa1-1418-43a6-b732-119e73b645be
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 8f11913d-81f5-4f99-91db-724003fc89f4
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 2604eafe-42eb-4e46-a89a-98a4c40643bb
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit a5275b33-8a7b-4808-b18f-78e221a64188
…
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to destroy 5b83d3af-3094-4ae7-ad26-3b1934361771
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to edit 173074d4-6730-49d4-b531-6cdd045abc0c
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to read bae85b8f-cc9f-4184-8cca-ebfd9f477558
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor Etd permissions is expected not to be able to update d7c343a5-3d4f-4f28-a973-ad36862ad9de
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to destroy a6b12e30-9b91-4de2-92ec-cfc607dd604a
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to edit d4ce3786-f3cd-47bc-957e-29091aa097ce
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to read 57cd3c62-d761-4ae7-a32d-3fd3d4445bc8
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor FileSet permissions is expected not to be able to update 06b37bc4-9586-4a34-8f81-4348e8f60f2e
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to destroy 1adecb9b-a77d-4c6d-bdd5-db609aa7849b
spec.abilities.work_ability_spec ‑ Hyrax::Ability::WorkAbility when work depositor GenericWork permissions is expected not to be able to edit 0efd0c0d-c903-4ef5-bb38-62a9bb8efbf1
…

♻️ This comment has been updated with latest results.

@@ -43,6 +43,6 @@
description: "Show General Login Link at Top Right of Page."

feature :treat_some_user_inputs_as_markdown,
default: true,
default: false,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feature was brought over from PALs specifically, i don't think it should be a default for ALL hyku

This commit will along the look of the catalog search results page to
look closer to the way Hyrax looks.  The problem stems from the
markdown feature.  For plain text it adds a `<p>` tag which has a margin
bottom.  I think the best thing to do is turn it off for default and any
tenant that is currently using it should turn it back on.
@kirkkwang kirkkwang merged commit 394fc04 into main Sep 23, 2024
8 checks passed
@kirkkwang kirkkwang deleted the search-results-styling branch September 23, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch-ver for release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants