use a helper for lease/embargo expiration #4304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no-reply
force-pushed
the
embargo-lease-helpers
branch
2 times, most recently
from
fdc2f58
to
1b4d8c8
Compare
these views relied on internal knowledge about Embargo and Lease implementations that likely won't hold under Valkyrie models. extracting this knoweldege into a helper method is a first step toward making it implementation agnostic. this is connected to samvera/hydra-head#511.
no-reply
force-pushed
the
embargo-lease-helpers
branch
from
1b4d8c8
to
54013dd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
these views relied on internal knowledge about Embargo and Lease implementations
that likely won't hold under Valkyrie models. extracting this knowledge into a
helper method is a first step toward making it implementation agnostic.
this is connected to samvera/hydra-head#511.
Guidance for testing, such as acceptance criteria or new user interface behaviors:
@samvera/hyrax-code-reviewers