expand the EmbargoManager interface to handle releasing embargos
#4305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 7, 2020 16:10
for Valkyrie models, we provide `Hyrax::EmbargoManager` to make the embargo lifecycle easy to work with. to date, this has only supported applying embargoes. this adds the ability to release an embargo after its period has expired. a concept of 'enforcement' is added, represented by `#enforced?`. this addresses the issue of embargoes which are not current (their period is past) but have not yet been released. the terminology used by the `EmbargoManager` is documented. see also: samvera/hydra-head#511.
`LeaseManager` is substantially similar to `EmbargoManager`, and got in without tests, with the idea that a refactor might quickly take place. it didn't and at this point it needs a test harness if that's ever going to happen. in the meanwhile. there are features we want to add to cover the remainder of the lifecycle.
no-reply
force-pushed
the
embargo-manager-expansion
branch
from
dd75bf7
to
a43faee
Compare
no-reply
force-pushed
the
embargo-manager-expansion
branch
from
146743a
to
4e868ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for Valkyrie models, we provide
Hyrax::EmbargoManagerto make the embargolifecycle easy to work with. to date, this has only supported applying
embargoes. this adds the ability to release an embargo after its period has expired.
a concept of 'enforcement' is added, represented by
#enforced?. this addressesthe issue of embargoes which are not current (their period is past) but have not
yet been released.
the terminology used by the
EmbargoManageris documented.see also: samvera/hydra-head#511.
@samvera/hyrax-code-reviewers