feat: Add course selection modal to catalog page #209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- Add AddCoursesModal component with search, virtualization, and deferred values - Convert catalog page to server component - Add term name fetching on server - Integrate modal into scheduler FilterPanel - Add CourseSearchResult type to lib/types - Improve modal UI with card-based design and better states
- Modal now separates locked and unlocked courses when generating - Pass locked course keys from server to display correct lock state - CourseBox displays lock icon based on actual locked state (read-only) - Update modal to pass both locked and optional course IDs separately
- Modal now keeps selected courses when generating schedules - Users can adjust their selection and regenerate without re-selecting - Added initialSelectedCourses and onSelectedCoursesChange props - FilterPanel manages the selected courses state
- Modal now closes after generating schedules - Remove state syncing that caused setState during render - Selected courses persist within same session
kaiyangzheng
force-pushed
the
add-scheduler-nav-icon
branch
from
24a0849 to
a121e1d
Compare
kaiyangzheng
force-pushed
the
add-scheduler-nav-icon
branch
from
57ddeec to
9be6b4d
Compare
sanjana-singhania
requested review from
ItsEricSun,
aarowz and
jpnortonwastaken
ItsEricSun
requested changes
Dec 10, 2025
| className="text-muted-foreground hover:bg-muted hover:text-foreground rounded p-1.5 transition-colors" | ||
| title="Course info" | ||
| > | ||
| <Info className="h-4 w-4" /> |
Contributor
There was a problem hiding this comment.
Does this info button do anything right now?
| title={course.isLocked ? "Unlock course" : "Lock course"} | ||
| > | ||
| {course.isLocked ? ( | ||
| <Lock className="h-4 w-4" /> |
Contributor
There was a problem hiding this comment.
I think this lock should turn red when its locked like how it is in the sidebar.
| </div> | ||
|
|
||
| {/* Child Courses (Recitations/Labs) */} | ||
| {course.children.length > 0 && ( |
Contributor
There was a problem hiding this comment.
Does this actually do anything right now, looking at the frontend I dont think I see any child courses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REBASED ON MAIN
Summary
- Implements the Add Courses modal on the catalog page with full course selection functionality.
Changes
- New
AddCoursesModalcomponent with two-column layout- Real-time course search via
/api/searchendpoint- Course selection (add/remove, max 10 courses)
- Lock/unlock toggle for selected courses
- Generate schedules button (navigates to scheduler page)
- Term display name conversion (shows "Spring 2026" instead of "202630")
- Loading states and error handling
- Backend API integration with debounced search
Testing
- [x] Modal opens from catalog page
- [x] Course search works with real API data
- [x] Add/remove courses functionality
- [x] Lock/unlock toggle works
- [x] Generate schedules navigates correctly
- [x] Term display name shows correctly
Future Work (not in this PR)
- Campus filtering (placeholder implemented)
- Child sections (recitations/labs)
- Info button functionality