Skip to content

Conversation

@ross3102
Copy link
Collaborator

@ross3102 ross3102 commented Feb 6, 2024

  • Add electron via capacitor
  • Add electron build to pnpm build script
  • Create separate scripts pnpm build:dev to build with dev params and pnpm dev:electron to run electron locally
  • Allow API to be run in secure mode (required by electron for cross-origin cookie policy reasons)

Note: files in electron directory are mostly auto-generated

Closes #17

@ross3102 ross3102 requested a review from DavidOB1 February 6, 2024 05:08
Copy link
Contributor

@DavidOB1 DavidOB1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-config code looks pretty standard so I'm approving for now but before merging we should make sure this runs correctly on other peoples' machines and add instructions if further steps are needed.

{
"name": "Brain Game Center",
"version": "1.0.0",
"description": "An Amazing Capacitor App",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This goes so hard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add electron

3 participants