DNM: potential improvements to Instrument modeling#726
Draft
rileyjmurray wants to merge 5 commits intocptp-instrumentsfrom
Draft
DNM: potential improvements to Instrument modeling#726rileyjmurray wants to merge 5 commits intocptp-instrumentsfrom
rileyjmurray wants to merge 5 commits intocptp-instrumentsfrom
Conversation
added 5 commits
July 1, 2025 20:17
Initial implementation of instrument availability resolution and automatic embedding for explicit models. In addition to changes to support availability resolution for instruments, a new class for representing ideal instrument specifications has been added. Also in this commit, a new helper function for built-in instrument specifications in internalgates.
Checkpoint progress on implementing instrument support for implicit models.
Add logic for serializing and deserializing newly added instrument specifications. Modify the deserialization logic in processor specifications to handle instrument specifications. This is a work in progress and will break compatibility with serialization of processor specifications that are instantiated with older style dictionary and string specifications. At least until I implement casting logic for InstrumentSpec. Also fix small bug in the deserialization of TPInstrument.
Update the logic of the processor specification inference logic to work with update instrument conventions and InstrumentSpecs. Add in automatic availability resolution similar to gates. Remove the bare 2-tuple specifier option for instrument specs, to reduce number of edge cases needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@pcwysoc left a comment on another Instrument-related PR with an iPython notebook: #693 (comment). That notebook didn't run on the branch of the PR in question. I've done a little looking and found this branch, which seems to contain the necessary infrastructure. In particular, this branch has the InstrumentSpec class that's imported at the beginning of the notebook.
Piper, when you get a chance, please submit a review of this PR indicating what functionality is well-developed and worth porting, versus what was never fully developed. You don't need to be terribly detailed. I'm not planning on merging this PR.
Also ping @coreyostrove, since it seems you authored the commits on this branch.