chore(ts): drop deprecated baseUrl from web/docs tsconfigs - #91
Closed
sandydasari wants to merge 1 commit into
Closed
chore(ts): drop deprecated baseUrl from web/docs tsconfigs#91sandydasari wants to merge 1 commit into
sandydasari wants to merge 1 commit into
Conversation
baseUrl is deprecated for removal in TypeScript 7.0 (newer editor TS already surfaces the warning). Since TS 5.0, "paths" resolves relative to the tsconfig directory without baseUrl, so "baseUrl": "." is a no-op here. Removing it clears the deprecation; check-types passes unchanged for both apps. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Deploying openacme-ai with
|
| Latest commit: |
42f32c5
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cd396ff1.openacme-ai.pages.dev |
| Branch Preview URL: | https://fix-baseurl-deprecation.openacme-ai.pages.dev |
Owner
Author
|
Folding this into #90 instead — the baseUrl tsconfig fix is now a commit on that branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes
"baseUrl": "."fromapps/web/tsconfig.jsonandapps/docs/tsconfig.json.Why
Newer TypeScript surfaces
Option 'baseUrl' is deprecated and will stop functioning in TypeScript 7.0. Since TS 5.0,pathsresolves relative to the tsconfig's own directory withoutbaseUrl, so"baseUrl": "."was a no-op next to the existingpaths: { "@/*": ["./*"] }. Dropping it clears the deprecation now rather than waiting for the 7.0 bump.The repo's pinned
typescript@5.9.2doesn't error on this yet (CI was green); the warning only appears in editors running a newer TS — but the fix is harmless and future-proofs the bump.Verification
pnpm --filter web check-typesandpnpm --filter docs check-typespass unchanged.pnpm build+ pre-commit/pre-pushcheck-typesgreen.@/*alias is configured independently of tsconfig, so bundler resolution is unaffected.🤖 Generated with Claude Code