Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 20, 2025

The "watch function should initialize without crashing" test is flaky on macOS.

Changes:

  • Add retry option to the test using Vitest's retry configuration
  • The test will retry up to 3 times on macOS if it fails (process.platform === 'darwin' ? 3 : 0)
  • Other platforms (Linux, Windows) run the test without retries

This approach allows the test to run on macOS and potentially pass on subsequent attempts while handling flakiness gracefully, rather than skipping it entirely.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI mentioned this pull request Nov 20, 2025
@changeset-bot
Copy link

changeset-bot bot commented Nov 20, 2025

⚠️ No Changeset found

Latest commit: 7315aa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copilot AI changed the title [WIP] Update version packages for release Skip flaky watch test on macOS Nov 20, 2025
Copilot AI requested a review from stipsan November 20, 2025 16:51
Copilot finished work on behalf of stipsan November 20, 2025 16:51
@squiggler squiggler bot force-pushed the changeset-release/main branch from 349c015 to e52e888 Compare November 20, 2025 18:14
Base automatically changed from changeset-release/main to main November 20, 2025 18:55
@stipsan
Copy link
Member

stipsan commented Nov 24, 2025

@copilot can it be skipped if it fails instead of always skipped? Or maybe just retry? Maybe we can set some retry options instead?

Copy link
Contributor Author

Copilot AI commented Nov 24, 2025

@copilot can it be skipped if it fails instead of always skipped? Or maybe just retry? Maybe we can set some retry options instead?

Changed to use Vitest's retry option instead. The test will now retry up to 3 times on macOS if it fails, allowing it to run and potentially pass rather than being skipped entirely. Fixed in 7315aa2.

Copilot AI changed the title Skip flaky watch test on macOS Add retry logic for flaky watch test on macOS Nov 24, 2025
Copilot finished work on behalf of stipsan November 24, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants