-
Notifications
You must be signed in to change notification settings - Fork 5
Add retry logic for flaky watch test on macOS #2249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Co-authored-by: stipsan <[email protected]>
349c015 to
e52e888
Compare
|
@copilot can it be skipped if it fails instead of always skipped? Or maybe just retry? Maybe we can set some retry options instead? |
Co-authored-by: stipsan <[email protected]>
Changed to use Vitest's retry option instead. The test will now retry up to 3 times on macOS if it fails, allowing it to run and potentially pass rather than being skipped entirely. Fixed in 7315aa2. |
The "watch function should initialize without crashing" test is flaky on macOS.
Changes:
retryconfigurationprocess.platform === 'darwin' ? 3 : 0)This approach allows the test to run on macOS and potentially pass on subsequent attempts while handling flakiness gracefully, rather than skipping it entirely.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.