Skip to content

Conversation

@RomanBurhenne
Copy link

When i run the loop diagrams, the inputs and outputs of the splitter and mixer branches were inversed. This way it works.

When i run the loop diagrams, the inputs and outputs of the splitter and mixer branches were inversed. This way it works.
@codecov-io
Copy link

codecov-io commented Mar 22, 2017

Codecov Report

Merging #149 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master     #149   +/-   ##
=======================================
  Coverage   60.25%   60.25%           
=======================================
  Files          51       51           
  Lines        4786     4786           
=======================================
  Hits         2884     2884           
  Misses       1902     1902
Impacted Files Coverage Δ
eppy/useful_scripts/loopdiagram.py 80.06% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf65af...293d947. Read the comment docs.

@santoshphilip
Copy link
Owner

@RomanBurhenne , Thanks for fixing that.
I had no idea that it was doing it wrong.

I'll review the code and merge in a few days.

@santoshphilip
Copy link
Owner

@RomanBurhenne , your update looks straightforward. The original loopdiagram.py seems broken for some reason. I need to look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants