Fixed the loopdiagram stuff #151
Open
+1,025
−918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/loopdiagram). And added a séparation between makeplantloop and makeairloop.
This should be against the `develop` branch in any case so probably won't be merged. I'm just interested if the tests will pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ex_loopdiagram.py now in /useful_scripts/loopdiagram.py.
and I added a couple of things in this file (fixed the argparse that was crashing on Py3x, made flags to be able to draw or not PlantLoops, and AirLoops) (edited)
I fixed the HVAC_tutorial.ipynb too