Skip to content

sap_vm_provision: Fix adding /etc/hosts for all in play not just itself #160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
marcelmamula merged 1 commit into from
Mar 20, 2026
Merged

sap_vm_provision: Fix adding /etc/hosts for all in play not just itself #160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions roles/sap_vm_provision/tasks/common/set_etc_hosts.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,19 +43,19 @@
loop:
# Since scaleout hosts are in same group, we have to skip it as it has separate file
- "{{ [sap_vm_provision_dynamic_inventory_hana_primary_ip, sap_vm_provision_dynamic_inventory_hana_primary_hostname]
if __sap_vm_provision_fact_is_hana_primary and not __sap_vm_provision_fact_is_hana_scaleout else '' }}"
if sap_vm_provision_dynamic_inventory_hana_primary_ip is not none and not __sap_vm_provision_fact_is_hana_scaleout else '' }}"

- "{{ [sap_vm_provision_dynamic_inventory_anydb_primary_ip, sap_vm_provision_dynamic_inventory_anydb_primary_hostname]
if __sap_vm_provision_fact_is_anydb_primary else '' }}"
if sap_vm_provision_dynamic_inventory_anydb_primary_ip is not none else '' }}"

- "{{ [sap_vm_provision_dynamic_inventory_nw_ascs_ip, sap_vm_provision_dynamic_inventory_nw_ascs_hostname]
if __sap_vm_provision_fact_is_nwas_ascs and (ansible_play_hosts_all | length) > 1 else '' }}"
if sap_vm_provision_dynamic_inventory_nw_ascs_ip is not none and (ansible_play_hosts_all | length) > 1 else '' }}"

- "{{ [sap_vm_provision_dynamic_inventory_nw_pas_ip, sap_vm_provision_dynamic_inventory_nw_pas_hostname]
if __sap_vm_provision_fact_is_nwas_pas else '' }}"
if sap_vm_provision_dynamic_inventory_nw_pas_ip is not none else '' }}"

- "{{ [sap_vm_provision_dynamic_inventory_nw_aas_ip, sap_vm_provision_dynamic_inventory_nw_aas_hostname]
if __sap_vm_provision_fact_is_nwas_aas and (ansible_play_hosts_all | length) > 1 else '' }}"
if sap_vm_provision_dynamic_inventory_nw_aas_ip is not none and (ansible_play_hosts_all | length) > 1 else '' }}"

loop_control:
loop_var: hosts_item
Expand Down
Loading