Skip to content

sap_general_preconfigure: Ansible 2.24 compatibility#1183

Open
berndfinger wants to merge 3 commits intosap-linuxlab:devfrom
berndfinger:sap_general_preconfigure_INJECT_FACTS_AS_VARS
Open

sap_general_preconfigure: Ansible 2.24 compatibility#1183
berndfinger wants to merge 3 commits intosap-linuxlab:devfrom
berndfinger:sap_general_preconfigure_INJECT_FACTS_AS_VARS

Conversation

@berndfinger
Copy link
Member

This is a subset of #1182 and replaces it for sap_general_preconfigure.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except unnecessary change to when list.

Signed-off-by: Bernd Finger <bfinger@redhat.com>
Signed-off-by: Bernd Finger <bfinger@redhat.com>
Copy link
Contributor

@marcelmamula marcelmamula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ja9fuchs ja9fuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants