Skip to content

relaxed validation check to pass podman quirk #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fcruzcscs merged 1 commit into from
Nov 7, 2025
Merged

relaxed validation check to pass podman quirk #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions common/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,15 +54,22 @@ func ValidateRoStore(path string) error {
return nil
}

// Validate that at least Podman-overlay Store subdirectories are present
requiredSubdirs := []string{"overlay", "overlay-images", "overlay-layers"}
for _, dir := range requiredSubdirs {
// Accept any of the common podman-overlay store subdirs is present
hasSubdirs := false
storeSubdirs := []string{"overlay", "overlay-images", "overlay-layers"}
for _, dir := range storeSubdirs {
fullPath := filepath.Join(path, dir)
if err := IsDir(fullPath); err != nil {
return fmt.Errorf("storage validation failed: %w", err)
if _, err := os.Stat(fullPath); err == nil {
// We found a subdir, we can break loop
hasSubdirs = true
break
}
}
if !hasSubdirs {
return fmt.Errorf("storage validation failed, non-empty and does not look like a podman-overlay store")
}

// Good enough check, dir looks like a podman overlay store
return nil
}