fix: escape item.id and item.category in showcase card HTML attributes#85
Merged
sauravbhattacharya001 merged 1 commit intomasterfrom Mar 28, 2026
Merged
Conversation
Apply _escapeHtml() to item.id, item.category, and the category CSS class name in _renderCard() to prevent attribute injection XSS. While current usage generates these values client-side, this hardens against future changes where data might come from external sources. Fixes #84
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
Bot
added
app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Apply
_escapeHtml()toitem.id,item.category, and the category CSS class name in_renderCard()to prevent attribute-context XSS injection.While current usage generates these values client-side (safe), this hardens against future changes where showcase data might come from external sources (API, URL params).
Changes
data-idattribute values (article + like button)data-categoryattribute valueFixes #84