fix: guard typing indicator template against non-browser environments#89
Merged
sauravbhattacharya001 merged 1 commit intomasterfrom Mar 28, 2026
Merged
Conversation
- _typingIndicatorTemplate IIFE would crash at load time in SSR/Node contexts where 'document' is undefined. Now guarded with typeof check, returning null in non-browser environments. - Fixed 'let' → 'var' for codebase consistency (all other modules use var). - Fixed misleading comment in init.js (handles 4 modules, not just WorkflowBuilder).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
github-actions
Bot
added
app
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code cleanup: SSR safety and consistency
Changes
SSR crash fix -
_typingIndicatorTemplatewas created via an IIFE that callsdocument.createElementunconditionally at bundle load time. In SSR/Node environments, this would throw a ReferenceError. Now guarded withtypeof document !== 'undefined'.lettovarconsistency - The typing template was the only file usingletwhile the entire codebase usesvarfor ES5 compatibility.Misleading comment -
init.jscomment said "Workflow Builder init" but it initializes 4 modules. Updated to be accurate.No breaking changes
Backward compatible - the template is still eagerly created in browser environments and the public API is unchanged.