-
Notifications
You must be signed in to change notification settings - Fork 508
Add "versionScheme" labels to pull-requests. #2925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
An additional label is added that reflect the versionScheme of the updated artifact. This is a new label. The existing labels have not been changed to ensure compatibility.
Codecov ReportBase: 90.63% // Head: 90.65% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2925 +/- ##
==========================================
+ Coverage 90.63% 90.65% +0.01%
==========================================
Files 155 155
Lines 3064 3070 +6
Branches 221 216 -5
==========================================
+ Hits 2777 2783 +6
Misses 287 287
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
I like this! The only thing I would change is how the label is rendered. I would prefer I'd also note that this label is purely informational in case of If we have the |
Good suggestion, I adapted the label format. /cc @julienrf (because you suggested the feature) |
@exoego Are you waiting for further changes or can we merge this? |
I first thought to roll your suggestion into this PR, but didn't found the time. Will merge the PR in it's current version. |
An additional label is added that reflect the
versionScheme
of the updated artifact. This is a new label. The existing labels have not been changed to ensure compatibility.versionScheme
reference: https://www.scala-sbt.org/1.x/docs/Publishing.html#Version+schemefixes #2541