Skip to content

Conversation

fthomas
Copy link
Member

@fthomas fthomas commented Feb 11, 2023

This adds a simple instance-wide PR throttle. It can be activated by adding the --pr-throttle-skip=$duration or --pr-throttle-wait=$duration command-line options. With --pr-throttle-skip=$duration Scala Steward will skip creating PRs for $duration after the last PR. With --pr-throttle-wait=$duration it actively waits until $duration is elapsed before creating the next PR.

Closes #2934, closes #2355

@armanbilge
Copy link
Contributor

Thank you so much! This strategy is easy to understand and will work well for us 👍

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

❌ Patch coverage is 69.44444% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.68%. Comparing base (ef3cd47) to head (1783dd9).
⚠️ Report is 1155 commits behind head on main.

Files with missing lines Patch % Lines
...calasteward/core/nurture/PullRequestThrottle.scala 11.11% 8 Missing ⚠️
...org/scalasteward/core/application/StewardAlg.scala 0.00% 2 Missing ⚠️
...ala/org/scalasteward/core/nurture/NurtureAlg.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2970      +/-   ##
==========================================
- Coverage   90.96%   90.68%   -0.28%     
==========================================
  Files         157      159       +2     
  Lines        3209     3253      +44     
  Branches      242      224      -18     
==========================================
+ Hits         2919     2950      +31     
- Misses        290      303      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@barryoneill
Copy link
Contributor

Hi @fthomas - is there any plan to bring this in?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More strategies for (org-level) throttling of PRs Deal with GitHub's secondary rate limit
3 participants