bugfix: Fix enumeration issues when Value is imported #23124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwijnand
approved these changes
May 9, 2025
There was a problem hiding this comment.
Looks reasonable. Maybe it risks making non-conflicting alias symbols to be fully qualified (e.g. val alias prefix?). But it's using the fully qualified name as a fallback (though without root there is still some risk).
Perhaps you want to add the "fully qualified name" caveat in code, so it's documented in more than just the PR.
We still add the full prefix in case of conflicts, but that's the current status quo. Making prefixes shorter is something we need to work on separately.
dwijnand
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still not a perfect fix, since we add the full prefix, but that's the current status quo. Making prefixes shorter is something we need to work on separately.