Make consume a soft modifier #23755
Open
Make consume a soft modifier #23755
+1,958
−1,150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odersky
force-pushed
the
change-consume
branch
2 times, most recently
from
c529d9a to
b89eb41
Compare
bracevac
approved these changes
Aug 15, 2025
- Split doc page into individual sub-pages - Add new material on classifiers - Revise material on scoped caps TODO - Revise material on reach capabilities - Add material on how to use the capture checker - Add material on separation checking - Check everything for completeness and accuracy Also: Add two test files named `reference-cc.scala` in neg and pos that let us try out the code on the doc pages. TODO: Complete these files so that all relevant code is there.
Files should also be listed in sidebar.yml.
Replaced hand-written intra-doc links with automatic doctool linking. Sidebar now reflects the subsection hierarchy.
Also remove redundant headings
The first paragraph of a doc page is rendered as some sort of synopsis/subtitle, which looked awkward with the current text. This change adds introduction headings, which also improves the navigation on the right-hand side of a page.
This has to be in sync with `docs/sidebar.yml`
& let the root document be an index, consistent with the style of other chapters of the reference. There is also no need to manually write the ToC with an index page.
Internally, it is still represented as an annotation
odersky
force-pushed
the
change-consume
branch
from
6f99bc9 to
4b8db82
Compare
hamzaremmal
reviewed
Aug 15, 2025
| @@ -995,6 +995,10 @@ class Namer { typer: Typer => | |||
| end if | |||
| } | |||
|
|
|||
| private def normalizeFlags(denot: SymDenotation)(using Context): Unit = | |||
| if denot.is(Method) && denot.hasAnnotation(defn.ConsumeAnnot) then | |||
| denot.setFlag(Mutable) | |||
There was a problem hiding this comment.
This means that scaladoc will always render consume update instead of consume.
It will have to be fixed.
There was a problem hiding this comment.
Yes, that would be nice to fix on scaladoc. Currently consume update is allowed, but the update is redundant.
There was a problem hiding this comment.
Currently consume update is allowed, but the update is redundant
I see what I can do to make it also a warning. The scaladoc fix is trivial.
hamzaremmal
reviewed
Aug 15, 2025
hamzaremmal
reviewed
Aug 15, 2025
hamzaremmal
reviewed
Aug 15, 2025
hamzaremmal
approved these changes
Aug 15, 2025
hamzaremmal
added a commit
that referenced
this pull request
Aug 16, 2025
With the given example:
```scala
import caps.consume
import scala.language.experimental.captureChecking
class Test extends caps.Mutable:
@consume def test(@consume x: Int)(using @consume y: Int): Unit = ()
```
It renders as following:
<img width="1051" height="281" alt="Screenshot 2025-08-15 at 16 11 05"
src="https://github.com/user-attachments/assets/022e5c58-827f-42ec-bdd7-938d019f2678"
/>
Related to #23755
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally, it is still represented as an annotation.
Based on #23709