Clean up Settings - #27005
Draft
SolalPirelli wants to merge 10 commits into
Draft
Clean up Settings#27005SolalPirelli wants to merge 10 commits into
SolalPirelli wants to merge 10 commits into
Conversation
SolalPirelli
commented
Sep 8, 2026
| s.name.startsWith("-Y") && s.name != "-Y" | ||
| protected def isHelping(s: Setting[?])(using settings: ConcreteSettings)(using SettingsState): Boolean = | ||
| cond(s.value) { | ||
| case ss: List[?] if s.isMultivalue => ss.contains("help") |
SolalPirelli
force-pushed
the
solal/clean-settings
branch
from
September 9, 2026 08:04
4decc33 to
e288fff
Compare
SolalPirelli
commented
Sep 9, 2026
SolalPirelli
force-pushed
the
solal/clean-settings
branch
2 times, most recently
from
September 11, 2026 08:35
e868f50 to
2034fab
Compare
SolalPirelli
force-pushed
the
solal/clean-settings
branch
from
September 14, 2026 12:37
2034fab to
340c8ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Delete dead code, make stuff private where possible
Have you relied on LLM-based tools in this contribution?
No
How was the solution tested?
Covered by existing tests (this is a refactoring)