Conversation
Added import statement for using 'into' as a type constructor, required in following examples.
tanishiking
reviewed
Sep 10, 2026
Member
There was a problem hiding this comment.
As you mentioned, into is defined a few lines later in scala.Conversion. Asking for import Conversion.into above that definition feels a bit wired to me.
Also, it looks as if every later snippets requires the import, but some of them actually don't (like Example 1 call site).
What do you think about adding import Conversion.into in Example 2 instead? Then I think readers can infer import Conversion.into is required for every into usage as a type constructor.
Author
|
Thank you for response. Yes, this approach seems appropriate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code examples in the documentation demonstrate the use of an
intotype constructor without explicitimportstatements. While the documentation's description ofinto's location implies the need for an import, I believe this documentation is incomplete. Therefore, I've added explicit documentation about the need for an import. The phrasing may still be improved.Have you relied on LLM-based tools in this contribution?
No