Support Symbol name in @deprecatedName - #27048
Open
SolalPirelli wants to merge 4 commits into
Open
SolalPirelli wants to merge 4 commits into
SolalPirelli wants to merge 4 commits into
Conversation
som-snytt
approved these changes
Sep 10, 2026
som-snytt
left a comment
som-snytt
left a comment
Contributor
There was a problem hiding this comment.
The accepted idiom is a bit narrow. Other computed Symbol args are still silently ignored.
som-snytt
reviewed
Sep 10, 2026
Contributor
Author
|
@som-snytt you're right, I added handling for this and tests |
SolalPirelli
force-pushed
the
solal/deprecatedName-symbol
branch
from
September 11, 2026 14:04
629f5c6 to
e703048
Compare
SolalPirelli
commented
Sep 11, 2026
| val rep = new StringBuilder | ||
| if failed == 0 && failedTests.isEmpty then | ||
| rep.append(s"${Console.BOLD}${Console.GREEN}== Vulpix Test Report: $passed suites passed, no failures (${skippedTests.size} skipped) ==${Console.RESET}") | ||
| rep.append(s"${Console.BOLD}${Console.GREEN}== Vulpix Test Report: all $passed suites passed (${skippedTests.size} skipped) ==${Console.RESET}") |
Contributor
Author
There was a problem hiding this comment.
Matt wanted to not see this when grepping for "failure"
Member
There was a problem hiding this comment.
Amazing, this will change my life, thank you! 🥳
som-snytt
reviewed
Sep 14, 2026
| def i( | ||
| @deprecatedName(Symbol("x" + 1)) a: Int // error | ||
| ): Int = a | ||
|
|
Contributor
There was a problem hiding this comment.
Scala 2 supports
def j(@deprecatedName(since = "forever", name = Symbol("x")) a: Int): Int = a
but doesn't issue deprecation when args are swapped.
This commit does not support
@deprecatedName(name = Symbol("x"))
That is probably tolerable. When can the deprecated constructor be removed? Soon enough.
som-snytt
approved these changes
Sep 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27042
Fixes #27038
Have you relied on LLM-based tools in this contribution?
No
How was the solution tested?
New automated tests (including the issue's reproducer, if applicable)