Skip to content

Improve logging response after submitting dependencies#346

Merged
tgodzik merged 5 commits into
scalacenter:mainfrom
dancewithheart:fix-191-log-response
Apr 17, 2026
Merged

Improve logging response after submitting dependencies#346
tgodzik merged 5 commits into
scalacenter:mainfrom
dancewithheart:fix-191-log-response

Conversation

@dancewithheart
Copy link
Copy Markdown
Contributor

Fix #191

From my tests this:

state.log.info(s"Submitting dependency snapshot of job $job to $snapshotUrl")

looks in logs like this:

Submitting dependency snapshot of job ... to https://api.github.com/repos/dancewithheart/temporary-scala-vulns-watch/dependency-graph/snapshots

and is rendered by browser as URL but it is not valid URL (for GET requests) as it returns 404.

So I changed that to:

state.log.info(s"Submitting dependency snapshot of job $job to GitHub Dependency Graph API")

because later snapshotUrl/snapshotId is logged:

"submission-api-url" -> s"$snapshotUrl/$snapshotId"

and that is actually valid URL for sending GET requests :)

we should log the httpResp response body

added httpRespo to logs:

s"GitHub submission response: ${httpResp.bodyAsString}"

Copy link
Copy Markdown
Contributor

@tgodzik tgodzik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

@tgodzik tgodzik merged commit 703fc2f into scalacenter:main Apr 17, 2026
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Submission result URL is not a valid Github API endpoint - "message": "Not Found" error

2 participants