Feature/SK-1519 | FEDn container uses distroless image #868
Conversation
stefanhellander
changed the title
stefanhellander
changed the title
| # Stage 1: Builder | ||
| ARG BASE_IMG=python:3.12-slim | ||
| FROM $BASE_IMG AS builder | ||
| FROM python:3.11-slim AS builder |
There was a problem hiding this comment.
The distroless image seems to be 3.11
| wget -qO /build/grpc_health_probe https://github.com/grpc-ecosystem/grpc-health-probe/releases/download/${GRPC_HEALTH_PROBE_VERSION}/grpc_health_probe-linux-amd64 && \ | ||
| chmod +x /build/grpc_health_probe; \ | ||
| fi | ||
| RUN mkdir /python-dist \ |
There was a problem hiding this comment.
RUN mkdir /python-dist
&& pip install --upgrade pip
&& pip install --prefix=/python-dist --no-cache-dir 'setuptools>=65' .
Wrede
left a comment
Wrede
left a comment
There was a problem hiding this comment.
On your note, there are no shell scripts running in the image? In the CI tests scripts are run in ubuntu images provided by github.
The "hooks" container did assume a shell existed, but that can be fixed. However, it won't be possible to run clients in these containers as they execute a script as a subprocess using "bash" (like the training script). |
Description
Switch to a "distroless" base image.
Note that it will not be possible to run shell scripts in this image, so integration tests are not working.