Skip to content

Conversation

@pgolm
Copy link

@pgolm pgolm commented Dec 9, 2025

The Scaleway Jobs API supports configuring local storage capacity for job definitions, but this option was not exposed in the Terraform provider. This change adds the local_storage_capacity attribute to allow users to specify local storage in MiB for their job containers.

@pgolm pgolm requested review from a team and remyleone as code owners December 9, 2025 17:36
remyleone
remyleone previously approved these changes Dec 10, 2025
@remyleone
Copy link
Member

Thanks a lot for your contribution :)

@remyleone remyleone enabled auto-merge December 10, 2025 10:22
auto-merge was automatically disabled December 10, 2025 15:30

Head branch was pushed to by a user without write access

@pgolm pgolm force-pushed the feat/job-definition-local-storage-capacity branch 2 times, most recently from 330917c to f07f3f2 Compare December 10, 2025 15:50
@pgolm
Copy link
Author

pgolm commented Dec 10, 2025

I've fixed the tests.

@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2025

Codecov Report

❌ Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 1.71%. Comparing base (6900a12) to head (5720805).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
internal/services/jobs/jobs.go 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##           master   #3521      +/-   ##
=========================================
- Coverage    1.71%   1.71%   -0.01%     
=========================================
  Files         434     434              
  Lines       47517   47527      +10     
=========================================
  Hits          813     813              
- Misses      46616   46626      +10     
  Partials       88      88              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@remyleone remyleone enabled auto-merge December 18, 2025 10:03
@remyleone
Copy link
Member

@pgolm I think your commits are not signed yet

The Scaleway Jobs API supports configuring local storage capacity for
job definitions, but this option was not exposed in the Terraform
provider. This change adds the local_storage_capacity attribute to
allow users to specify local storage in MiB for their job containers.
auto-merge was automatically disabled December 19, 2025 08:39

Head branch was pushed to by a user without write access

@pgolm pgolm force-pushed the feat/job-definition-local-storage-capacity branch from 5720805 to 0e4a53d Compare December 19, 2025 08:39
@pgolm
Copy link
Author

pgolm commented Dec 19, 2025

@remyleone Thanks for the hint! The commit is now signed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants