Skip to content

feat: order summary #4794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from
Open

feat: order summary #4794

wants to merge 16 commits into from

Conversation

lisalupi
Copy link
Contributor

@lisalupi lisalupi commented Feb 19, 2025

Summary

Type

  • Feature

Summarise concisely:

  • New component OrderSummary
  • <UnitInput />: new prop selectInputMaxWidth

@lisalupi lisalupi self-assigned this Feb 19, 2025
Copy link

changeset-bot bot commented Feb 19, 2025

🦋 Changeset detected

Latest commit: 1c5365f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/plus Minor
@ultraviolet/form Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.37%. Comparing base (97855a0) to head (1c5365f).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4794      +/-   ##
==========================================
+ Coverage   84.31%   89.37%   +5.05%     
==========================================
  Files          37      235     +198     
  Lines         663     8232    +7569     
  Branches      216     3775    +3559     
==========================================
+ Hits          559     7357    +6798     
- Misses        104      875     +771     
Files with missing lines Coverage Δ
...kages/form/src/components/UnitInputField/index.tsx 100.00% <ø> (ø)
packages/ui/src/components/UnitInput/index.tsx 98.95% <100.00%> (ø)

... and 197 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc698aa...1c5365f. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mhervouet
Copy link

mhervouet commented Apr 8, 2025

Capture d’écran 2025-04-08 à 12 26 04

Wrong spacing here. Title must be vertically centered with the unit input.

@mhervouet
Copy link

mhervouet commented Apr 8, 2025

Capture d’écran 2025-04-08 à 12 25 58

Spacing between icon on text must be 0.25rem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants