Skip to content

fix: selectableCard height #4946

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

lisalupi
Copy link
Contributor

Summary

Type

  • Bug

Summarise concisely:

What is expected?

There was an issue with the height of a SelectableCard with a tooltip :

  • Add prop containerFullHeight to Popup and Tooltip,
  • Use it to fix height issue for SelectableCard

@lisalupi lisalupi added the bug Something isn't working label Mar 27, 2025
@lisalupi lisalupi requested a review from a team March 27, 2025 15:20
@lisalupi lisalupi self-assigned this Mar 27, 2025
@lisalupi lisalupi requested review from matthprost and Lawndlwd and removed request for a team March 27, 2025 15:21
@lisalupi lisalupi requested review from johnrazeur, a team and matthprost as code owners March 27, 2025 15:21
Copy link

changeset-bot bot commented Mar 27, 2025

🦋 Changeset detected

Latest commit: 5dd7305

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Mar 27, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.36%. Comparing base (c7f83fa) to head (5dd7305).
Report is 6 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4946   +/-   ##
=======================================
  Coverage   89.36%   89.36%           
=======================================
  Files         235      235           
  Lines        8228     8228           
  Branches     3768     3768           
=======================================
  Hits         7353     7353           
  Misses        875      875           
Files with missing lines Coverage Δ
packages/ui/src/components/Popup/index.tsx 89.04% <ø> (ø)
...ackages/ui/src/components/SelectableCard/index.tsx 96.09% <ø> (ø)
packages/ui/src/components/Tooltip/index.tsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dacaba5...5dd7305. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants