improvement: perform get bucket and object at once #931
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello vrancurel,My role is to assist you with the merge of this Status report is not available. |
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
Peer approvals must include at least 1 approval from the following list: |
|
@bert-e wait |
dora-korpar
reviewed
Feb 6, 2020
| ], {}, (err, cursor) => { | ||
| if (err) { | ||
| log.error( | ||
| 'getBucketAttributes: error getting bucket attributes', |
There was a problem hiding this comment.
not necessary to start benchmark testing, but if we keep this combined approach, this error message should change
|
Closing this PR as parallelization #932 generates better results. |
|
Actually sometimes aggregates generate better results too |
Instead of doing 2 round trips we perform the 2 queries at once using an aggregate.
vrancurel
force-pushed
the
improvement/ZENKO-2307/get-bucket-and-object-aggregate
branch
from
3cc863a to
96f933d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of doing 2 round trips we perform the 2 queries at once using an
aggregate.
This PR is to check that we pass the end-to-end tests. You can review but we do not want to merge unless we are sure it improves the performance.