Improvement/cldsrv 724 multiple backend tests #5960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-multiple-backend-tests
branch
from
1769d66 to
4619bab
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files
@@ Coverage Diff @@
## improvement/CLDSRV-724-kms-tests-migration #5960 +/- ##
==============================================================================
+ Coverage 71.77% 74.07% +2.30%
==============================================================================
Files 188 188
Lines 12130 12130
==============================================================================
+ Hits 8706 8985 +279
+ Misses 3424 3145 -279
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-multiple-backend-tests
branch
from
4619bab to
76ab4cc
Compare
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-multiple-backend-tests
branch
from
76ab4cc to
fc9608c
Compare
Comment on lines
94
to
96
| throw new Error('Expected NoSuchKey error but got success'); | ||
| } catch (err) { | ||
| assert.strictEqual(err.code, 'NoSuchKey'); |
There was a problem hiding this comment.
I think as you throw in the try, that we will enter the assert of the catch and fail the check, then we loose the inital error you thrown, and we'll see an asert failure with "undefined" that is not "NoSuchKey", can be misleading
(same other places)
Comment on lines
74
to
76
| .then(() => { | ||
| done(new Error('Expected failure but got success')); | ||
| }) |
There was a problem hiding this comment.
Suggested change
| .then(() => { | |
| done(new Error('Expected failure but got success')); | |
| }) | |
| .then(() => done(new Error('Expected failure but got success'))) |
Comment on lines
-145
to
-146
| it('should delete object from AWS location with bucketMatch set to ' + | ||
| 'false', done => { |
There was a problem hiding this comment.
I think this test was removed, is this expected?
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-multiple-backend-tests
branch
from
e031412 to
1c923f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: CLDSRV-724