Migration aws sdk v2 to v3 : removeDeleteMarkers

[SylvainSenechal]

Issue : S3UTILS-204

[bert-e]

Hello sylvainsenechal,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options

name	description	privileged	authored
/after_pull_request	Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval	Bypass the pull request author's approval	⭐
/bypass_build_status	Bypass the build and test status	⭐
/bypass_commit_size	Bypass the check on the size of the changeset TBA	⭐
/bypass_incompatible_branch	Bypass the check on the source branch prefix	⭐
/bypass_jira_check	Bypass the Jira issue check	⭐
/bypass_peer_approval	Bypass the pull request peers' approval	⭐
/bypass_leader_approval	Bypass the pull request leaders' approval	⭐
/approve	Instruct Bert-E that the author has approved the pull request.		✍️
/create_pull_requests	Allow the creation of integration pull requests.
/create_integration_branches	Allow the creation of integration branches.
/no_octopus	Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity	Change review acceptance criteria from one reviewer at least to all reviewers
/wait	Instruct Bert-E not to run until further notice.

Available commands

name	description	privileged
/help	Print Bert-E's manual in the pull request.
/status	Print Bert-E's current status in the pull request TBA
/clear	Remove all comments from Bert-E from the history TBA
/retry	Re-start a fresh build TBA
/build	Re-start a fresh build TBA
/force_reset	Delete integration branches & pull requests, and restart merge process from the beginning.
/reset	Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

[francoisferrand]

catch must not wrap the callback: otherwise, if the callback throws, we will call it again....

---

best way is to stick to a single approach:

• if the function being implemented (i.e. getObjMd) is a callback API, probably best to use the promise directly : client.send().then(...)
• if the function is async/promise-based (or updated this), then we can and should indeed use await

and/or we can make a trampoline to ease transition (in the same or different functions):

async function getObjMd(params, cb) {
   if (cb) {
       return getObjMd(params).then(result -> cb(null, result), cb);
   }

   // no need for catch actually, since that is the way to return the error!
   return await client.send(...);
} 

[francoisferrand]

note: we need to make this PR correct, but to avoid too much changes we can also choose to be less ambitious (not moving to "proper" async yet, just use callbacks and promises), and upgrade to async later (in separate PR)

[SylvainSenechal]

I see, I reverted it

[francoisferrand]

same here: catch must not wrap the callback: otherwise, if the callback throws, we will call it again....

[francoisferrand]

same here: catch must not wrap the callback: otherwise, if the callback throws, we will call it again....

[bert-e]

Waiting for approval

The following approvals are needed before I can proceed with the merge:

• the author

• 2 peers

[SylvainSenechal]

Not fully related to this pr whose goal is to migrate removeDeleteMarkers, but I made a mistake in one of the previous ones, mixing callback and catch, so I'm fixing it here